-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for capitalize to text-transform #2170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9978e64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Tonkpils
force-pushed
the
tonkpils/text-capitalize
branch
from
July 31, 2023 21:13
ba66278
to
4a8149a
Compare
Tonkpils
force-pushed
the
tonkpils/text-capitalize
branch
from
July 31, 2023 21:15
4a8149a
to
ec5cc5f
Compare
Tonkpils
force-pushed
the
tonkpils/text-capitalize
branch
from
July 31, 2023 21:23
fc3e0af
to
d3933ce
Compare
Tonkpils
force-pushed
the
tonkpils/text-capitalize
branch
from
July 31, 2023 21:29
cd2315d
to
95de131
Compare
camertron
requested changes
Jul 31, 2023
keithamus
approved these changes
Jul 31, 2023
Tonkpils
force-pushed
the
tonkpils/text-capitalize
branch
from
August 1, 2023 21:49
95de131
to
79f3f12
Compare
camertron
approved these changes
Aug 1, 2023
Shoot, sorry @Tonkpils! That change to utilities.yml was required to get tests to pass. I ran |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Add support for capitalize on text-transform. It's already supported by the CSS class
text-capitalize
https://primer.style/design/foundations/css-utilities/typography#typographic-stylesRisk Assessment
What approach did you choose and why?
Added the change to the list where these utilities are already defined
Anything you want to highlight for special attention from reviewers?
Is there anything else that needs to be updated?
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.